feat(NODE-5207): deprecate unsupported runCommand options and add spec tests #3643
+892
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nbbeeken
force-pushed
the
NODE-5202-runCommand
branch
from
c70010e to
2e26e93
Compare
nbbeeken
changed the title
nbbeeken
added
the
Primary Review
dariakp
changed the title
dariakp
previously approved these changes
Apr 21, 2023
dariakp
added
Team Review
dariakp
requested changes
Apr 21, 2023
dariakp
previously approved these changes
Apr 25, 2023
dariakp
changed the title
durran
requested changes
Apr 26, 2023
src/cmap/connection.ts
Outdated
| @@ -488,18 +488,19 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> { | |||
| options: CommandOptions | undefined, | |||
| callback: Callback | |||
| ): void { | |||
| const readPreference = getReadPreference(cmd, options); | |||
| cmd = { ...cmd }; | |||
There was a problem hiding this comment.
Although this leaves the supplied command untouched outside of the scope of this method can we assign it to a new const to avoid any potential confusion?
dariakp
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
DRIVERS-2577
mongodb/specifications#1389
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript