fix(NODE-4475): make interrupted message more specific #3437
+92
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
Oct 6, 2022
There was a problem hiding this comment.
From tech chat - let's try to add tests that
- confirm a change stream resumes if it encounters a resumable error with
interruptedin the error message - confirm that a change stream does not resume if it encounters an error with
operation was interruptedas the message
Also - @durran want to file a follow up ticket to investigate removing the two special cases here?
https://jira.mongodb.org/browse/NODE-4717 is created. |
durran
added
the
Primary Review
baileympearson
approved these changes
Oct 13, 2022
baileympearson
added
Team Review
dariakp
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes change stream retryability on 4.4 servers and lower when performing a failover.
What is changing?
This is the "quick and dirty" fix that just avoids pushing a
nullto the readable cursor stream before callingdestroyon the stream when the error contains the message "interrupted at shutdown".Existing spec tests cover the more specific error - see: https://github.com/mongodb/node-mongodb-native/blob/main/test/spec/retryable-writes/legacy/insertOne-serverErrors.yml#L468
Note: see #3438 for what a start of a refactor away from checking for this error message and creating separate streams for the change stream cursor and the others would look like. However it seems the "operation was interrupted" message affects change streams as well so I'll leave it as draft for now.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4475
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>