Skip to content

fix(NODE-2035): Exceptions thrown from awaited cursor forEach do not propagate #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2021
Merged

fix(NODE-2035): Exceptions thrown from awaited cursor forEach do not propagate #2852

merged 5 commits into from
Jun 24, 2021
+76 −2

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jun 17, 2021 •
edited
Loading

Description

Catch and propagate exceptions in awaited cursor.forEach
What changed?

  • lib/cursor.js
  • test/functional/cursor.test.js

W-A-James added 3 commits June 17, 2021 15:45
@W-A-James
test: Create test to ensure that exceptions are thrown from promised …

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
45af148 
…cursor.forEach
@W-A-James
fix: Wrap iterator call in try/catch block to propagate error
9348e4e
@W-A-James
test: Ensure that test calls done in all cases
d5a74dc
@W-A-James W-A-James requested a review from nbbeeken June 17, 2021 21:29
nbbeeken
nbbeeken requested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job translating the async/await to promises, one small chainable section missed in the afterEach

@W-A-James W-A-James requested a review from nbbeeken June 21, 2021 14:17
@emadum emadum self-requested a review June 21, 2021 14:32
nbbeeken
nbbeeken approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken requested review from dariakp and durran June 21, 2021 15:07
@nbbeeken nbbeeken added the Team Review Needs review from team label Jun 21, 2021
emadum
emadum approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dariakp
dariakp requested changes Jun 22, 2021
View reviewed changes
@W-A-James W-A-James requested a review from dariakp June 23, 2021 15:17
@nbbeeken nbbeeken merged commit a917dfa into 3.6 Jun 24, 2021
@nbbeeken nbbeeken deleted the NODE-2035/3.6/Exceptions-thrown-from-awaited-cursor-forEach-do-not-propagate branch June 24, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum

@nbbeeken nbbeeken

@dariakp dariakp

@durran durran

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@W-A-James @emadum @nbbeeken @dariakp