Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4738 - Make test_encryption.TestClientSimple.test_fork sync-only #1862

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

NoahStapp
Copy link
Contributor

@NoahStapp NoahStapp commented Sep 17, 2024

Asyncio and forking should not be mixed. I suspect the sync version was failing due to running after the async version caused a deadlock.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@NoahStapp NoahStapp requested a review from blink1073 September 17, 2024 14:45
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit 163e3d4 into mongodb:master Sep 17, 2024
34 checks passed
@NoahStapp NoahStapp deleted the PYTHON-4738 branch September 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants