Skip to content

PYTHON-4219 Prep for 4.6.2 Release #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

blink1073
Copy link
Member

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@blink1073 blink1073 requested a review from a team as a code owner February 20, 2024 18:01
@blink1073 blink1073 requested review from caseyclements and removed request for a team February 20, 2024 18:01
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to backport the fix for PYTHON-4147.

@@ -17,7 +17,7 @@

from typing import Tuple, Union

version_tuple: Tuple[Union[int, str], ...] = (4, 6, 2, ".dev0")
version_tuple: Tuple[Union[int, str], ...] = (4, 6, 2, "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we always remove the "".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


PyMongo 4.6.2 fixes the following bug:

- Python 3.12 thread error while using ``MongoClient()`` function.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the same changelog entry that's in 4.7:

- Fixed a bug appearing in Python 3.12 where "RuntimeError: can't create new thread at interpreter shutdown"
  could be written to stderr when a MongoClient's thread starts as the python interpreter is shutting down.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Verified

This commit was signed with the committer’s verified signature.
sxzz Kevin Deng 三咲智子
@blink1073
Copy link
Member Author

We still need to backport the fix for PYTHON-4147.

#1532

Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants