Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-3917 Fix handling of warnings in connection string tests #1357

Merged
merged 8 commits into from
Aug 18, 2023
Merged

PYTHON-3917 Fix handling of warnings in connection string tests #1357

merged 8 commits into from
Aug 18, 2023
+7 −5

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073
PYTHON-3917 [Build Failure] test_connection_string_test_valid-auth_At…

Verified

This commit was signed with the committer’s verified signature.
atollena Antoine Tollenaere
SSH Key Fingerprint: Qo4/u8/EWmiOhTj70w1VIOpWv3WpUkbKCabmZuemx98
Verified
Learn about vigilant mode
2fced01 
…-signs_in_options_aren_t_part_of_the_userinfo
@blink1073
debug

Verified

This commit was signed with the committer’s verified signature.
atollena Antoine Tollenaere
SSH Key Fingerprint: Qo4/u8/EWmiOhTj70w1VIOpWv3WpUkbKCabmZuemx98
Verified
Learn about vigilant mode
4f9489b
@blink1073
formatting

Verified

This commit was signed with the committer’s verified signature.
atollena Antoine Tollenaere
SSH Key Fingerprint: Qo4/u8/EWmiOhTj70w1VIOpWv3WpUkbKCabmZuemx98
Verified
Learn about vigilant mode
a595c79
@blink1073
debug

Verified

This commit was signed with the committer’s verified signature.
atollena Antoine Tollenaere
SSH Key Fingerprint: Qo4/u8/EWmiOhTj70w1VIOpWv3WpUkbKCabmZuemx98
Verified
Learn about vigilant mode
b6fdc9d
@blink1073
update debug message

Verified

This commit was signed with the committer’s verified signature.
atollena Antoine Tollenaere
SSH Key Fingerprint: Qo4/u8/EWmiOhTj70w1VIOpWv3WpUkbKCabmZuemx98
Verified
Learn about vigilant mode
e22233e
@blink1073
convert warnings to errors

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
1446ebc
@blink1073
ignore resource warnings

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
1ea0f7a
@blink1073
ignore resource warnings
Loading
Loading status checks…
4e93bf7
@blink1073 blink1073 requested a review from a team as a code owner August 17, 2023 14:01
@blink1073 blink1073 requested review from NoahStapp and removed request for a team August 17, 2023 14:01
@blink1073
Copy link
Member Author

blink1073 commented Aug 17, 2023 •
edited
Loading

Here's a passing build with a large set of tasks which would have triggered several of these failures before this change.

ShaneHarvey
ShaneHarvey approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could you open a new issue for the ResourceWarning? We should get to the bottom of those.

@blink1073
Copy link
Member Author

I opened https://jira.mongodb.org/browse/PYTHON-3923

@blink1073 blink1073 merged commit 5bd444a into mongodb:master Aug 18, 2023
@blink1073 blink1073 deleted the PYTHON-3917 branch August 18, 2023 00:10
@blink1073 blink1073 restored the PYTHON-3917 branch August 18, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey

@NoahStapp NoahStapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blink1073 @ShaneHarvey