Skip to content

PYTHON-3912 Migrate Enterprise Auth Tests to AWS Secrets Vault #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 18, 2023
Merged

PYTHON-3912 Migrate Enterprise Auth Tests to AWS Secrets Vault #1356

merged 22 commits into from
Aug 18, 2023

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@NoahStapp NoahStapp requested a review from a team as a code owner August 16, 2023 23:42
@NoahStapp NoahStapp requested review from blink1073 and removed request for a team August 16, 2023 23:42
blink1073
blink1073 requested changes Aug 17, 2023
View reviewed changes
@blink1073
Copy link
Member

blink1073 commented Aug 17, 2023 •
edited
Loading

To ensure isolation, can we please use include_expansions_in_env and only include the AWS creds that we'll use in the vault access?
We should do that for both this new test and the Atlas test.

@NoahStapp
Copy link
Contributor Author

To ensure isolation, can we please use include_expansions_in_env and only include the AWS creds that we'll use in the vault access? We should do that for both this new test and the Atlas test.

Can you explain this suggestion a little more? I thought we had agreed to not use EG expansions and were relying on only the secrets-export.sh file for populating secret values + AWS creds.

@blink1073
Copy link
Member

What I mean is, rather than use add_expansions_to_env, explicitly only allow the three AWS env variables, so we're not pulling all of the project variables.

@NoahStapp NoahStapp requested a review from blink1073 August 17, 2023 17:36
blink1073
blink1073 reviewed Aug 17, 2023
View reviewed changes
@NoahStapp NoahStapp requested a review from blink1073 August 17, 2023 21:42
blink1073
blink1073 reviewed Aug 18, 2023
View reviewed changes
@NoahStapp NoahStapp requested a review from blink1073 August 18, 2023 16:12
blink1073
blink1073 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit aaff6ed into mongodb:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoahStapp @blink1073