PYTHON-3821 use overload pattern for _DocumentType #1352
Merged
+71
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Aug 10, 2023
| @@ -1131,11 +1143,13 @@ def decode_all( | |||
| Replaced `as_class`, `tz_aware`, and `uuid_subtype` options with | |||
| `codec_options`. | |||
| """ | |||
| opts = codec_options or DEFAULT_CODEC_OPTIONS | |||
There was a problem hiding this comment.
What was wrong (according to mypy) with this code? I find the new code less readable since it calls _decode_all in multiple places.
There was a problem hiding this comment.
I was getting the following mypy error:
typecheck-mypy: commands[0]> mypy --install-types --non-interactive bson gridfs tools pymongo
bson/__init__.py: note: In function "decode_all":
bson/__init__.py:1150: error: Cannot infer type argument 1 of "_decode_all" [misc]
return _decode_all(data, opts)
^~~~~~~~~~~~~~~~~~~~~~~
Found 1 error in 1 file (checked 85 source files)
typecheck-mypy: exit 1 (2.96 seconds) /Users/iris.ho/GitHub/mongo-python-driver> mypy --install-types --non-interactive bson gridfs tools pymongo pid=40888
.pkg: _exit> python /Users/iris.ho/Library/Python/3.9/lib/python/site-packages/pyproject_api/_backend.py True setuptools.build_meta
typecheck-mypy: FAIL code 1 (10.28=setup[7.32]+cmd[2.96] seconds)
evaluation failed :( (10.35 seconds)
ShaneHarvey
reviewed
Aug 10, 2023
|
Yes! Just wrote some tests! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-3821