Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-3906 Use AWS Secrets for Atlas tests #1342

Merged
merged 18 commits into from
Aug 15, 2023
Merged

PYTHON-3906 Use AWS Secrets for Atlas tests #1342

merged 18 commits into from
Aug 15, 2023
+27 −33

Conversation

NoahStapp
Copy link
Contributor

No description provided.

blink1073
blink1073 reviewed Aug 4, 2023
View reviewed changes
@NoahStapp NoahStapp marked this pull request as ready for review August 7, 2023 17:51
@NoahStapp NoahStapp requested a review from a team as a code owner August 7, 2023 17:51
@NoahStapp NoahStapp requested review from sleepyStick and blink1073 and removed request for a team August 7, 2023 17:51
@NoahStapp
DRIVERS-2585 Use AWS Secrets Manager for AWS-Related Test Secrets

Verified

This commit was signed with the committer’s verified signature.
aquamatthias Matthias Veit
GPG key ID: 3A5DBA1696E83A38
Verified
Learn about vigilant mode
f6323f6
@NoahStapp
Test on EG with atlas-tests

Verified

This commit was signed with the committer’s verified signature.
aquamatthias Matthias Veit
GPG key ID: 3A5DBA1696E83A38
Verified
Learn about vigilant mode
c3069fe 
Test again

Use correct DET

Use tox properly

Correct utils.sh path

debug

prepare shell

Use correct working dir
@NoahStapp
Add aws-secrets label
e2286cc
@NoahStapp
Set AWS_ROLE_ARN
34fb128 
More AWS cred testing

More AWS cred testing

More AWS cred testing

testing

testing

More cleanup

Debugging

Debugging again

deubg 3.7

deubg 3.7

Security cleanup
@NoahStapp
Security cleanup
5ecb241 
Cleanup

Use add_expansions_to_env

Use add_expansions_to_env
@NoahStapp
Use add_expansions_to_env
45789f9
@NoahStapp
Cleanup
11bbf35
blink1073
blink1073 requested changes Aug 8, 2023
View reviewed changes
@NoahStapp NoahStapp requested a review from blink1073 August 8, 2023 21:20
@NoahStapp NoahStapp requested a review from blink1073 August 11, 2023 22:00
blink1073
blink1073 reviewed Aug 14, 2023
View reviewed changes
@NoahStapp NoahStapp requested a review from blink1073 August 14, 2023 18:38
@NoahStapp NoahStapp removed the request for review from sleepyStick August 14, 2023 18:44
blink1073
blink1073 reviewed Aug 15, 2023
View reviewed changes
@NoahStapp NoahStapp requested a review from blink1073 August 15, 2023 16:54
@NoahStapp
Remove test-atlas from tox
Loading
Loading status checks…
bc6dc4c
@blink1073
Copy link
Member

Can you change the PR title to target PYTHON-3906 please?

@NoahStapp NoahStapp changed the title DRIVERS-2585 Use AWS Secrets Manager for AWS-Related Test Secrets PYTHON-3906 Use AWS Secrets for Atlas tests Aug 15, 2023
@NoahStapp
Copy link
Contributor Author

Doccheck is failing for these 4 links:

(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/2d/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/2d/
(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/2dsphere/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/2dsphere/
(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/index-hashed/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/index-hashed/
(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/index-text/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/index-text/

@blink1073
Copy link
Member

Doccheck is failing for these 4 links:

Can you please open a ticket to track these failures?

@NoahStapp
Copy link
Contributor Author

Doccheck is failing for these 4 links:

Can you please open a ticket to track these failures?

Done, https://jira.mongodb.org/browse/PYTHON-3915.

blink1073
blink1073 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 42c0841 into mongodb:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NoahStapp @blink1073