Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1023: Provide OS variant when building mongohoused #997

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Oct 24, 2022

PHPLIB-1023

This resolves error with our go config to make Atlas Data Lake tests run again. Previous build failures are resolved through the libmongoc update in mongodb/mongo-php-driver#1377

Patch Build

This resolves error with our go config
@alcaeus alcaeus requested a review from jmikola October 24, 2022 07:14
@alcaeus alcaeus self-assigned this Oct 24, 2022
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment suggestion.

Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
@alcaeus alcaeus merged commit 1a4eed8 into mongodb:master Oct 25, 2022
@alcaeus alcaeus deleted the phplib-1023-fix-adl-tests branch October 25, 2022 06:10
alcaeus added a commit to alcaeus/mongo-php-library that referenced this pull request Oct 25, 2022
* PHPLIB-1023: Provide OS variant when building mongohoused

This resolves error with our go config

* Update .evergreen/config.yml

Co-authored-by: Jeremy Mikola <jmikola@gmail.com>

Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants