Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1153: Add FunctionalTestCase::skipIfServerVersion($op, $version) #1107

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 14, 2023

@GromNaN GromNaN requested review from jmikola and alcaeus June 14, 2023 14:28
@GromNaN GromNaN force-pushed the PHPLIB-1153 branch 2 times, most recently from b33f203 to fa23d96 Compare June 15, 2023 08:10
@GromNaN GromNaN requested a review from jmikola June 15, 2023 08:14
@GromNaN GromNaN changed the title PHPLIB-1153: Add helper method FunctionalTestCase::skipIfServerVersionNotSupported PHPLIB-1153: Add helper method FunctionalTestCase::skipIfServerVersion($op, $version) Jun 15, 2023
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the assertion message.

LGTM after that is fixed.

@GromNaN GromNaN changed the title PHPLIB-1153: Add helper method FunctionalTestCase::skipIfServerVersion($op, $version) PHPLIB-1153: Add FunctionalTestCase::skipIfServerVersion($op, $version) Jun 21, 2023
@alcaeus alcaeus merged commit 5a14dee into mongodb:master Jun 21, 2023
@GromNaN GromNaN deleted the PHPLIB-1153 branch June 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants