Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1040: Demonstrate enum handling in BSON tutorial #1004

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Nov 22, 2022

https://jira.mongodb.org/browse/PHPLIB-1040

I opted not to demonstrate Serializable implementations, which can be found in the PHPC tests. If/when type maps are extended to support callables, this content should be easy to extend.

Note: I also built the docs locally and confirmed that the links render correctly.

Verified

This commit was signed with the committer’s verified signature.
jmikola Jeremy Mikola
@jmikola jmikola requested a review from alcaeus November 22, 2022 09:41
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree with not documenting any additional functionality around serialising enums.

@jmikola
Copy link
Member Author

jmikola commented Nov 22, 2022

fast-rapid

@jmikola jmikola merged commit 818520c into mongodb:master Nov 22, 2022
@jmikola jmikola deleted the phplib-1040 branch November 22, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants