GODRIVER-2881 Enable logging for ComponentAll #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested review from
matthewdale and
qingyang-hu
and removed request for
a team and
matthewdale
qingyang-hu
reviewed
Aug 1, 2023
Comment on lines
+395
to
+402
| name: "component mismatch", | ||
| logger: Logger{ | ||
| ComponentLevels: map[Component]Level{ | ||
| ComponentCommand: LevelDebug, | ||
| }, | ||
| }, | ||
| level: LevelDebug, | ||
| component: ComponentTopology, |
There was a problem hiding this comment.
I think it will be better to have want explicitly.
qingyang-hu
reviewed
Aug 1, 2023
internal/logger/logger_test.go
Outdated
Comment on lines
351
to
352
| name: "nil", | ||
| want: false, |
There was a problem hiding this comment.
I think it will be better to have all zero values explicitly.
qingyang-hu
pushed a commit
that referenced
this pull request
Aug 1, 2023
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2881
Summary
Update the considerations for enabling a log to
Background & Motivation
There is a logging design oversight in which enabling logging with "options.LogComponentAll" does not result in the publication of logs. This issue arises because the "LevelComponentEnabled" method on the internal logger object fails to account for this specific use case.