GODRIVER-2887 bson: remove use of reflect.Value.MethodByName #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all uses of reflect.Value.MethodByName since it prevents deadcode elimination. This causes binaries built with the bson library to be larger than they need to be. Source: https://go.dev/src/cmd/link/internal/ld/deadcode.go#L293
matthewdale
changed the title
qingyang-hu
approved these changes
Jul 5, 2023
prestonvasquez
approved these changes
Jul 5, 2023
|
Thank you all for the quick review! |
qingyang-hu
pushed a commit
that referenced
this pull request
Aug 1, 2023
prestonvasquez
pushed a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
prestonvasquez
pushed a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
prestonvasquez
pushed a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
prestonvasquez
pushed a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2887
Summary
Remove all uses of reflect.Value.MethodByName since it prevents dead code elimination. This causes binaries built with the mongodb/mongo-go-driver library to be larger than they need to be.
All occurrences of reflect.Value.MethodByName are replaced with type assertions.
Source: https://go.dev/src/cmd/link/internal/ld/deadcode.go#L293
Background & Motivation
Reduce the size of binaries built with mongodb/mongo-go-driver.