Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2869 Test touchup #1307

Merged
merged 1 commit into from Jun 28, 2023
Merged

Conversation

qingyang-hu
Copy link
Collaborator

GODRIVER-2869

Summary

  • Parallelize new tests
  • Add a test to reproduce the infinite loop

Background & Motivation

A test touchup following a888dc6

_, src, ok := readLengthBytes([]byte{0x00, 0x00, 0x00, 0x01})
t.Parallel()

_, src, ok := readLengthBytes([]byte{0x01, 0x00, 0x00, 0x00})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the order to represent the length of 1 to check against the new code.

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@qingyang-hu qingyang-hu merged commit 8489898 into mongodb:master Jun 28, 2023
17 of 20 checks passed
qingyang-hu added a commit that referenced this pull request Aug 1, 2023
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Aug 1, 2023
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Aug 1, 2023
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Aug 1, 2023
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants