v2.21.0 Documentation fixes #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstam
requested changes
Aug 10, 2023
| @@ -120,7 +120,7 @@ public interface IMongoSearchIndexManager | |||
| /// <param name="aggregateOptions">The aggregate options.</param> | |||
| /// <param name="cancellationToken">The cancellation token.</param> | |||
| /// <returns> | |||
| /// A Task whose result is a cursor. | |||
| /// A task whose result is a cursor. | |||
There was a problem hiding this comment.
Task with a capital T is a class name.
| public IBsonSerializer<TDerived> DerivedSerializer => _derivedSerializer; | ||
|
|
||
| /// <inheritdoc/> |
There was a problem hiding this comment.
This is an explicitly implemented interface property and therefore private. Why does it even need <inheritdoc/>?
| @@ -130,6 +130,7 @@ public interface IMongoSearchIndexManager | |||
| /// <param name="name">Name of the index.</param> | |||
| /// <param name="definition">The definition.</param> | |||
| /// <param name="cancellationToken">The cancellation token.</param> | |||
| /// <returns>A task.</returns> | |||
| @@ -138,6 +139,7 @@ public interface IMongoSearchIndexManager | |||
| /// <param name="name">Name of the index.</param> | |||
| /// <param name="definition">The definition.</param> | |||
| /// <param name="cancellationToken">The cancellation token.</param> | |||
| /// <returns>A task.</returns> | |||
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.