-
Notifications
You must be signed in to change notification settings - Fork 257
test(NODE-5692): Add new benchmarks using bson-bench #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+198,913
−652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Nov 15, 2023
nbbeeken
requested changes
Nov 15, 2023
nbbeeken
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small follow up Qs, LGTM
nbbeeken
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Important
Note to reviewers The diff-size of this PR is large mostly due to the addition of the generated test files. To ensure that these files have been generated properly, review
test/bench/etc/generate_documents.ts
and look at the smallest file possible that relates to the case being reviewed.e.g. if reviewing how nested test documents were generated, look at
nested_4.json
as the larger documents are build in the same fashion, but will be difficult to load into an editorNew benchmarks
test/bench/granular
test/bench/spec
test/bench/documents
test/bench/etc/generate_documents.ts
and understanding these documents is better done by looking at the logic in this filetest/bench/etc
generate_documents.ts
- Regenerates documents intest/bench/documents
run_granular_benchmarks.js
- runs all compiled benchmarks intest/bench/lib/granular
and consolidates results intoresultsCollected.json
in perf.send formatconvertToCSV.js
- Reads in a data in perf.send format from stdin and writes it to stdout converted to a csv more easily ingestible by google sheets, or other data-analysis toolsCI changes
check:bench
script in package.json tocheck:granular-bench
test/bench/granular
and runsrun_granular_benchmarks.js
run granular benchmarks
function to config.yml.evergreen/run-granular-benchmarks.sh
run-granular-benchmarks-node-18
task in place ofrun-benchmarks-node-18
taskrun-granular-benchmarks-node-18
task on perf distributioncheck:spec-bench
script in package.json.evergreen/run-spec-benchmarks.sh
run spec benchmarks
function to config.ymlrun-spec-benchmarks-node-18
taskrun-granular-benchmarks-node-18
task on perf distributionRemovals
etc/benchmarks
test/bench/src
Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-5692
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript