(EAI-616)split test case into more isolated test cases #582
+70
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlarew
reviewed
Jan 9, 2025
packages/mongodb-rag-core/src/contentStore/MongoDbEmbeddedContentStore.test.ts
Show resolved
Hide resolved
nlarew
reviewed
Jan 9, 2025
packages/mongodb-rag-core/src/contentStore/MongoDbEmbeddedContentStore.test.ts
Outdated
Show resolved
Hide resolved
nlarew
reviewed
Jan 21, 2025
Comment on lines
117
to
120
| const pageEmbeddings = await store.loadEmbeddedContent({ page }); | ||
| const anotherPageEmbeddings = await store?.loadEmbeddedContent({ | ||
| page: anotherPage, | ||
| }); |
There was a problem hiding this comment.
We should either use optional chaining (?.) on both of these call or neither
nlarew
reviewed
Jan 21, 2025
nlarew
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-616
Changes
test case "handles embedded content" was removed
test cases for loading and updating embedded content were added.
I noticed the test case "has an overridable default collection name" was listed twice, I removed one
Notes