feat(dl-center): add support for arbitrary acls COMPASS-9237 #525
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
reviewed
Apr 1, 2025
| @@ -235,8 +236,10 @@ export class DownloadCenter { | |||
| throw new Error('s3ObjectKey is required'); | |||
| } | |||
|
|
|||
| const acl = options.acl === undefined ? ACL_PUBLIC_READ : options.acl; | |||
There was a problem hiding this comment.
const acl = options.acl ?? ACL_PUBLIC_READ; should work and be more modern/idiomatic.
There was a problem hiding this comment.
nitpick, obviously. Feel free to ignore ;)
lerouxb
approved these changes
Apr 1, 2025
This commit adjusts our DownloadCenter's UploadAssetOptions to support taking an optional 'acl' parameter. When we upload an asset to S3, this parameter is used to set the ACL on the put request. If no acl is set, we default to "public-read" to preserve backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts our DownloadCenter's UploadAssetOptions to support taking an optional 'acl' parameter. When we upload an asset to S3, this parameter is used to set the ACL on the put request. If no acl is set, we default to "public-read" to preserve backward compatibility.