-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): enable coveralls MONGOSH-2125 #524
Conversation
* main: chore(ci): bump packages
run: npm run check-ci -- --stream | ||
shell: bash | ||
|
||
- name: Run Tests | ||
run: npm run test-ci -- --stream | ||
shell: bash | ||
|
||
- name: Report Coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi if you haven't considered it already: coveralls does have an official github action that could be worth considering, didn't look too much into it though, might not fit our setup: https://github.com/marketplace/actions/coveralls-github-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I looked at it, but the problem with it is that it's designed to report the results of a single package run, so I'd have to either add 20 steps to report coverage from each of the packages in the monorepo, or completely change how we're running CI to make it run one job per package in a matrix. The official action is using the CLI like we are and I did consult with its implementation when working on our reporting.
Description
Enables coveralls reporting. Example run: https://coveralls.io/builds/72998592.
Waiting on IT to get admin access to the repo on Coveralls and fix the monorepo settings.
Open Questions
Checklist