Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable coveralls MONGOSH-2125 #524

Merged
merged 10 commits into from
Apr 1, 2025
Merged

chore(ci): enable coveralls MONGOSH-2125 #524

merged 10 commits into from
Apr 1, 2025

Conversation

nirinchev
Copy link
Collaborator

@nirinchev nirinchev commented Mar 31, 2025

Description

Enables coveralls reporting. Example run: https://coveralls.io/builds/72998592.

Waiting on IT to get admin access to the repo on Coveralls and fix the monorepo settings.

Open Questions

Checklist

Sorry, something went wrong.

@nirinchev nirinchev changed the title chore(ci): run all checks always chore(ci): enable coveralls Mar 31, 2025
Base automatically changed from ni/run-checks to main March 31, 2025 12:38

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nirinchev nirinchev requested review from Copilot and gagik and removed request for Copilot March 31, 2025 12:40
Copilot

This comment was marked as off-topic.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* main:
  chore(ci): bump packages
@nirinchev nirinchev changed the title chore(ci): enable coveralls chore(ci): enable coveralls MONGOSH-2125 Mar 31, 2025
@nirinchev nirinchev marked this pull request as ready for review March 31, 2025 13:54
run: npm run check-ci -- --stream
shell: bash

- name: Run Tests
run: npm run test-ci -- --stream
shell: bash

- name: Report Coverage
Copy link
Collaborator

@gagik gagik Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi if you haven't considered it already: coveralls does have an official github action that could be worth considering, didn't look too much into it though, might not fit our setup: https://github.com/marketplace/actions/coveralls-github-action

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I looked at it, but the problem with it is that it's designed to report the results of a single package run, so I'd have to either add 20 steps to report coverage from each of the packages in the monorepo, or completely change how we're running CI to make it run one job per package in a matrix. The official action is using the CLI like we are and I did consult with its implementation when working on our reporting.

@nirinchev nirinchev merged commit 26a21b6 into main Apr 1, 2025
6 checks passed
@nirinchev nirinchev deleted the ni/coveralls branch April 1, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants