chore(ci): run all checks always MONGOSH-2125 #523
Merged
+268
−442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
force-pushed
the
ni/run-checks
branch
from
c0f1fee to
80aa3f0
Compare
nirinchev
commented
Mar 29, 2025
| command: string, | ||
| args: ReadonlyArray<string> | ||
| ): Promise<void> => { | ||
| const proc = spawn(command, args); |
There was a problem hiding this comment.
Using execFile from child_process was causing ENOENT trying to run npx on windows.
nirinchev
commented
Mar 29, 2025
| @@ -448,51 +448,137 @@ describe('@mongodb-js/shell-bson-parser', function () { | |||
| toISOString: (${newDate}).toISOString(), | |||
| valueOf: (${newDate}.valueOf()), | |||
| }`; | |||
| expect(parse(input, options)).to.deep.equal({ | |||
There was a problem hiding this comment.
Had to rework this test due to race conditions where the test run could span multiple milliseconds, resulting in failures when comparing the fields that have millisecond precision.
addaleax
approved these changes
Mar 31, 2025
nirinchev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the CI workflows to always run all tests, not just changed ones and fixes the tests failing on main.
Open Questions
Checklist