Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Fix issue #4985 and add createError method #5599

Closed
wants to merge 1 commit into from

Conversation

Alanscut
Copy link
Contributor

@Alanscut Alanscut commented Jun 16, 2020

Changes

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 88.502% when pulling e57bff0 on Alanscut:issue_4985 into 528ac2b on moment:develop.

@Alanscut Alanscut changed the title [feature]Fix issue #4985 and add createError method [feature] Fix issue #4985 and add createError method Sep 15, 2020
@ichernev
Copy link
Contributor

Merged in c8785e7

ichernev added a commit that referenced this pull request Dec 23, 2023
[feature] Enable exceptions for invali moments

Fixes #4985
@ichernev ichernev closed this Dec 24, 2023
@ichernev
Copy link
Contributor

Reverted in 0f0195f.

I looked carefully at all the places the new createError calls, and most of them didn't make any sense. I'm guessing the function that returns an invalid moment should be wrapped in this method. Then it can be made to either print, or throw, or do nothing (the default).

ichernev added a commit that referenced this pull request Dec 26, 2023
This reverts commit c8785e7, reversing
changes made to b4e0676.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants