Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a dev migrating from Moment.js who just lost a couple of hours to the fact that
toFormat
doesn't default to the user's own locale. I figured I might help others by adding some tweaks to the docs.My changes are two-fold:
format
in Moment.js andtoFormat
in Luxon aren't fully equivalent to each other. In Moment.js,format
is the preferred way of formatting dates, even for human-readable strings.toFormat
to clarify that the default locale isen-US
.Re #2, in the contributing guidelines you say that you prefer gotchas to go in the docstrings, but considering
toFormat
already has a dedicated section for internationalization and I'm not the first person to run into this, I hope you'll consider making a minor exception.