Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayPluginUpdates: default minimum maven version should not be assumed to be the same as the one for versions-maven-plugin #995

Closed
jarmoniuk opened this issue Jul 30, 2023 · 0 comments · Fixed by #996
Labels
Milestone

Comments

@jarmoniuk
Copy link
Contributor

jarmoniuk commented Jul 30, 2023

DisplayPluginUpdates will use the minimum version of Maven required to execute versions-maven-plugin to also be the minimum Maven version for the project that is being analysed. However, I see no reason why this should be the case. That would only be the case if the versions plugin is used in the POM, but obviously doesn't have to be the case.

In other words: we cannot make assumptions about the version required to execute the project based on the version that is currently being used to run versions-maven-plugin. Those can be different.

I think the assumption should be dropped.

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jul 30, 2023
…ugin should is not the minimum version for the project
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Jul 30, 2023
…ugin should is not the minimum version for the project
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Aug 19, 2023
…ugin should is not the minimum version for the project
@slawekjaranowski slawekjaranowski added this to the next-release milestone Aug 20, 2023
slawekjaranowski pushed a commit that referenced this issue Aug 20, 2023
…uld is not the minimum version for the project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants