Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwarranted "Circular property definition" #27

Closed
julienwilliams opened this issue Mar 18, 2016 · 5 comments · Fixed by #28
Closed

Unwarranted "Circular property definition" #27

julienwilliams opened this issue Mar 18, 2016 · 5 comments · Fixed by #28
Labels
Milestone

Comments

@julienwilliams
Copy link

Running in 1.0.0

Running the following Test Unit fails but should not. It should be possible to reference the same property twice in another property as this is not a circular reference.

@Test
public void unwarrantedCircularReferenceError() throws MojoFailureException
{
    Properties properties = new Properties();
    properties.setProperty( "port", "8080" );
    properties.setProperty( "myCustomProperty", "http://${port}:${port}/" );

    String value = resolver.getPropertyValue( "myCustomProperty", properties, new Properties() );

    assertEquals( "http://8080:8080/", value );
}

Thank you,

Julien Williams

psenechal-stingray added a commit to psenechal-stingray/properties-maven-plugin that referenced this issue Mar 22, 2016
@ayen-tibco
Copy link

Can someone push out a new release for this plugin to get this bug fix?Thanks.

@Zefiro
Copy link

Zefiro commented Mar 20, 2017

I also just stumbled upon this issue. Does the proposed fix from 2016-03-22 (two days short of one year back) solve this issue? If so, I'd appreciate if it could be merged.

@bobtiernay-okta
Copy link

Would it be possible to release version 1.0.1 which contains the fix? Much appreciated!

FYI - found this via https://stackoverflow.com/questions/39710828/maven-circular-property-definition.

@bobtiernay-okta
Copy link

@olamy Would this be something you could assist with?

@G-AyyappaLokesh
Copy link

Could someone please assist for above issue as not able to find any solution for above issue.
Thank for advance.

@slawekjaranowski slawekjaranowski linked a pull request Jun 20, 2023 that will close this issue
@slawekjaranowski slawekjaranowski added this to the 1.2.0 milestone Jun 20, 2023
slawekjaranowski pushed a commit that referenced this issue Jun 21, 2023
* Fixed side effect on ExpansionBuffer::toString

* Fixed #27 Unwarranted circular property definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants