Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Can't find license-maven-plugin" in 1.16 if plugin isn't configured in the POM #139

Closed
digulla opened this issue Jun 6, 2018 · 2 comments
Closed

"Can't find license-maven-plugin" in 1.16 if plugin isn't configured in the POM #139

digulla opened this issue Jun 6, 2018 · 2 comments
Labels
add-third-party bug help wanted
Milestone
Backlog

Comments

@digulla
Copy link

digulla commented Jun 6, 2018

If you try to run mvn license:aggregate-add-third-party without adding the plugin to the root / parent POM first, you get the error Can't find license-maven-plugin throws in this line:

license-maven-plugin/src/main/java/org/codehaus/mojo/license/AggregatorAddThirdPartyMojo.java

Line 197 in 70b96df

throw new IllegalStateException("Can't find license-maven-plugin");

I see two solutions:

  1. Enhance the error message: "Please add the plugin to your POM"
  2. Put the three values in a property file (using resource filtering) and load that file from the classpath.
@ppalaga
Copy link
Contributor

ppalaga commented Jan 4, 2019

Thanks for the report. A PR with an integration test is welcome.

@ppalaga ppalaga added this to the Backlog milestone Feb 1, 2019
AndyGee added a commit to AndyGee/license-maven-plugin that referenced this issue Aug 5, 2019
@AndyGee
Fix mojohaus#139 - "Can't find license-maven-plugin"
9f060cb 
Use the PluginDescriptor.
Most painful checkstyle.
@ppalaga ppalaga closed this as completed in 24c6bc5 Aug 5, 2019
ppalaga added a commit that referenced this issue Aug 5, 2019
@ppalaga
Merge pull request #348 from AndyGee/AndyGee-139
01fd9a1 
Fix #139 - "Can't find license-maven-plugin"
AndyGee added a commit to AndyGee/license-maven-plugin that referenced this issue Jan 15, 2020
@AndyGee
Fix mojohaus#139 - "Can't find license-maven-plugin" (#1)
e72d4f9 
* Fix mojohaus#139 - "Can't find license-maven-plugin"

Use the PluginDescriptor.
Most painful checkstyle.
@AndyGee AndyGee mentioned this issue Jan 15, 2020
Closed
@rkraneis
Copy link

Why is this closed as completed? This issue still persists :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
add-third-party bug help wanted
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix #139 - "Can't find license-maven-plugin" (#1) AndyGee/license-maven-plugin
3 participants
@digulla @rkraneis @ppalaga