Properly handle UnsupportedOperationException thrown by Thread::stop in JDK 20+ #391
Comments
kriegaex
changed the title
|
@slawekjaranowski, sorry for mentioning you directly, but I guess you are the most active developer in this project. I massively edited this issue, because I realised that this is about more than just failing builds on JDK 20+. |
|
@kriegaex do you have a plan to fix it? |
|
@slawekjaranowski, actually I stumbled upon this one by chance while testing the other PR you just merged. I thought, I should document it, before I forget about it again. I had not thought about fixing it myself. OTOH, this weekend I might have some time to implement the minimal fix I sketched above and update the docs. If that is good enough for you to merge and you do not envision some kind of grand scheme solution, I can take a shot. |
kriegaex
added a commit
to kriegaex/exec-maven-plugin
that referenced
this issue
Nov 11, 2023
In JDK 20+, the long deprecated Thread.stop() (since JDK 1.2) has been removed and will throw an UnsupportedOperationException. This will be handled gracefully when using option 'stopUnresponsiveDaemonThreads', yielding a log warning "Thread.stop() is unavailable in this JRE version, cannot force-stop any threads" once and not trying to stop any further threads during the same execution. Tests and documentation have been adjusted accordingly. Closes mojohaus#391.
kriegaex
added a commit
to kriegaex/exec-maven-plugin
that referenced
this issue
Nov 11, 2023
Because mojohaus#391 introduces special handling of the fact that in JDK 20+ there is no more Thread::stop, we should also run the tests on JDK 21.
slawekjaranowski
pushed a commit
that referenced
this issue
Nov 11, 2023
* [#391] Cope with Thread::stop being unavailable in JDK 20+ In JDK 20+, the long deprecated Thread.stop() (since JDK 1.2) has been removed and will throw an UnsupportedOperationException. This will be handled gracefully when using option 'stopUnresponsiveDaemonThreads', yielding a log warning "Thread.stop() is unavailable in this JRE version, cannot force-stop any threads" once and not trying to stop any further threads during the same execution. Tests and documentation have been adjusted accordingly. Closes #391. * [#391] Add JDK 21 to CI build Because #391 introduces special handling of the fact that in JDK 20+ there is no more Thread::stop, we should also run the tests on JDK 21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since JDK 20,
Thread::stopthrows anUnsupportedOperationException, see the corresponding code change in OpenJDK. Actually, the method was deprecated since JDK 1.2 and slated for removal long ago, too. See also JDK-8204243. The rationale behind deprecation and how to better stop a thread are explained in Oracle's "Java Thread Primitive Deprecation".Not only does
ExecJavaMojoTest::testUncooperativeThreaduseThread::stop, which is why unit tests are failing since JDK 20, but more severely, mojoexec:javawill fail, too, if optionstopUnresponsiveDaemonThreadsis active. At the very least, anUnsupportedOperationExceptionmust be handled and reported inExecJavaMojo::terminateThreads. Furthermore, optionstopUnresponsiveDaemonThreadsshould be documented accordingly and its use be warned about with special notice of JDK 20+ where it has no effect (other than those exceptions I just mentioned).The text was updated successfully, but these errors were encountered: