SignatureChecker ignores annotation of enclosing class when checking field type

[Marcono1234]

It looks like SignatureChecker ignores whether the enclosing class is annotated (and errors should be ignored) when processing field types:

animal-sniffer/animal-sniffer/src/main/java/org/codehaus/mojo/animal_sniffer/SignatureChecker.java

Line 362 in 364fc20

checkType(Type.getType(descriptor), false);

This should probably be checkType(Type.getType(descriptor), ignoreError);.

[cpovirk]

I think I hit this, as well. I attempted to work around it by putting @IgnoreJRERequirement on the field itself, but that turns out not to be a valid target:

animal-sniffer/animal-sniffer-annotations/src/main/java/org/codehaus/mojo/animal_sniffer/IgnoreJRERequirement.java

Line 39 in 8c2eac0

@Target({ElementType.METHOD, ElementType.CONSTRUCTOR, ElementType.TYPE})

(At first, I was using our own custom @IgnoreJRERequirement annotation (background). That annotation is defined to allow us to place it on fields, but presumably Animal Sniffer doesn't look there for it, since it's not normally valid.)

[Marcono1234]

This is not fixed in 1.22; the comment on PR #139 erroneously referred to this issue (if I see that correctly). This can still be seen with the following simple example (using Java 5 signatures):

import java.util.Optional;
import org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement;

@IgnoreJRERequirement
class MyClass {
    // BUG: This is not ignored
    Optional<String> f;
    
    // This is ignored due to @IgnoreJRERequirement, as desired
    Optional<String> test() {
        return null;
    }
}

[TimvdLippe]

Can confirm that this issue has not been fixed yet: mockito/mockito#2735