[test-runner-commands] reset-mouse command is broken with newer versions of puppeteer

[melink14]

This is broken since v19.10.1 (due to puppeteer/puppeteer#10021) and unfortunately wasn't marked as a breaking change and so is in scope of the current version designation of the puppeteer package.

The breakage is caused by these lines:

web/packages/test-runner-commands/src/sendMousePlugin.ts

Line 170 in e0d362f

await page.mouse.up({ button: 'left' });

In latest versions of puppeteer, it's an error to call up if the mouse button is not actually pressed.

Users can implement their own reset commands to compensate (based on actual use) but I think the only easy common reset implementation would be to use try...catch to prevent bubbling expected errors.

[dlockhart]

I'm seeing this as well. Another alternative solution perhaps: track whether the 3 mouse buttons are up or down and then reset-mouse would only call mouse.up for the ones that require it.

[web-padawan]

This also affects unit tests with sendMouse that we use in Vaadin web components:

Error: 'left' is not pressed.
    at Mouse.up (/Users/serhii/vaadin/web-components/node_modules/@web/test-runner-chrome/node_modules/puppeteer-core/lib/cjs/puppeteer/common/Input.js:518:19)
    at Object.executeCommand (/Users/serhii/vaadin/web-components/node_modules/@web/test-runner-commands/dist/sendMousePlugin.js:114:38)
    at TestRunnerApiPlugin._onCommand (/Users/serhii/vaadin/web-components/node_modules/@web/test-runner-core/dist/server/plugins/api/testRunnerApiPlugin.js:145:108)

Update: the last working version is 19.9.0 and the change was introduced in 19.9.1.

[melink14]

The reset command was added in puppeteer/puppeteer#10340 and it looks like it's been released since puppeteer-core: v20.7.3 and browsers: v1.4.2 so I think this problem could be fixed with another update to those deps and then chaning the commands code to use reset instead of manually calling the mouse commands.

I guess since the deps are new major versions (some sort of breaking change) then it would mean the modernweb package would also need a new major version?

[web-padawan]

it would mean the modernweb package would also need a new major version?

Yes, we probably should update to these versions and use await page.mouse.reset() directly.
This would mean releasing @web/test-runner-commands version 0.8.0 due to major bump.