Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent array to string conversion in Subset matcher #1253

Merged
merged 2 commits into from May 3, 2023

Conversation

downsider
Copy link
Contributor

Fixes #1252

@ghostwriter ghostwriter changed the base branch from master to 1.6.x May 3, 2023 12:41
@ghostwriter ghostwriter self-assigned this May 3, 2023
@ghostwriter ghostwriter added Fixed for bug fixes or error corrections Patch Backwards compatible bug fixes and improvements labels May 3, 2023
@ghostwriter ghostwriter added this to the 1.6.0 milestone May 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1253 (05b11ed) into 1.6.x (aed9f5e) will increase coverage by 0.27%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##              1.6.x    #1253      +/-   ##
============================================
+ Coverage     77.43%   77.71%   +0.27%     
- Complexity      994      996       +2     
============================================
  Files            74       74              
  Lines          2526     2526              
============================================
+ Hits           1956     1963       +7     
+ Misses          570      563       -7     
Impacted Files Coverage Δ
library/Mockery/Matcher/Subset.php 100.00% <100.00%> (+35.00%) ⬆️

Copy link
Member

@ghostwriter ghostwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, going to proceed and merge this pull request.

Thank you.

@ghostwriter ghostwriter merged commit bac1765 into mockery:1.6.x May 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed for bug fixes or error corrections Patch Backwards compatible bug fixes and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: nested arrays cause array to string conversion in Subset
4 participants