Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypassing asdine/storm and directly using bbolt. #392

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Bypassing asdine/storm and directly using bbolt. #392

merged 6 commits into from
Apr 30, 2024

Conversation

werbenhu
Copy link
Member

For #390, Bypassing asdine/storm and directly using bbolt.

@coveralls
Copy link

coveralls commented Apr 23, 2024 •
edited

Pull Request Test Coverage Report for Build 8891794859

Details

  • 122 of 130 (93.85%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.622%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hooks/storage/bolt/bolt.go 114 122 93.44%
Files with Coverage Reduction New Missed Lines %
hooks/storage/bolt/bolt.go 4 96.67%
Totals Coverage Status
Change from base Build 8891610430: -0.2%
Covered Lines: 6157
Relevant Lines: 6243
💛 - Coveralls

mochi-co
mochi-co approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement over the existing implementation, and much easier to read and understand. Thank you so much @werbenhu! I'm going to merge this now.

@mochi-co mochi-co merged commit b26e03a into mochi-mqtt:main Apr 30, 2024
3 checks passed
@thedevop thedevop mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochi-co mochi-co mochi-co approved these changes

@thedevop thedevop Awaiting requested review from thedevop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@werbenhu @coveralls @mochi-co