Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eleventy template builds crash with 'unexpected token at ": string, msg..."' #5116

Conversation

LcsK
Copy link
Contributor

@LcsK LcsK commented Mar 7, 2024

PR Checklist

Overview

Eleventy wasn't being able to parse the JSDocs for the returned type on the getFullErrorStack function. Defining it as a new type and then referencing it on the function fixes the issue.
Running npm run docs on this branch should work now.

Eleventy wasn't being able to parse the JSDocs for the returned type
on the getFullErrorStack function. Defining it as a new type and then
referencing it on the function fixes the issue
Copy link

linux-foundation-easycla bot commented Mar 7, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Fix: Eleventy template builds crash with 'unexpected token at ": string, msg..."' fix: eleventy template builds crash with 'unexpected token at ": string, msg..."' Mar 7, 2024
@coveralls
Copy link

Coverage Status

coverage: 94.359%. remained the same
when pulling 3c87cba on LcsK:fix/eleventy/problem-writing-eleventy-templates
into 3735873 on mochajs:master.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit a2e600d into mochajs:master Mar 8, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Eleventy template builds crash with 'unexpected token at ": string, msg..."'
3 participants