Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Windows regression test for --mac-address #47283

Open
robmry opened this issue Jan 31, 2024 · 1 comment
Open

Add a Windows regression test for --mac-address #47283

robmry opened this issue Jan 31, 2024 · 1 comment
Assignees
Labels
area/networking kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Comments

@robmry
Copy link
Contributor

robmry commented Jan 31, 2024

Description

Try to implement a Windows regression test for the fix in #47233 (as described in its "how to verify").,

Reproduce

See the PR.

Expected behavior

There's a regression test.

docker version

n/a

docker info

n/a

Additional Info

No response

@robmry robmry added status/0-triage kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. labels Jan 31, 2024
@robmry robmry self-assigned this Jan 31, 2024
@robmry robmry added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/networking and removed kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. status/0-triage labels Jan 31, 2024
@robmry robmry changed the title Add a WIndows regression test for --mac-address Add a Windows regression test for --mac-address Jan 31, 2024
@robmry
Copy link
Contributor Author

robmry commented Feb 16, 2024

This turned out to be quite tricky ... the Windows tests all run under a single instance of the daemon, there's no existing way to set up a new daemon for a test (which, in this case, could be restarted). And, it's not simple to do - perhaps for many reasons, but at-least because on startup the Windows daemon looks for networks on the host and tidies up any networks it doesn't recognise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
None yet
Development

No branches or pull requests

1 participant