Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/tonistiigi/fsutil @ 497d33b #4863

Merged
merged 1 commit into from Apr 22, 2024

Conversation

profnandaa
Copy link
Collaborator

@profnandaa
Copy link
Collaborator Author

@tonistiigi -- first time doing vendoring here, lmk if this is the right way and also if I should wait for tonistiigi/fsutil#198 to go together with this.

@profnandaa profnandaa force-pushed the vendor-github_tonistiigi_fsutils branch from 46d99cc to 67193bb Compare April 22, 2024 09:21
@crazy-max
Copy link
Member

Looks like go.sum is not aligned: https://github.com/moby/buildkit/actions/runs/8781650519/job/24094104027?pr=4863#step:5:439

You can run make vendor to make sure of it

Full diff: https://github.com/tonistiigi/fsutil/compare/7525a1af2bb5..497d33b

Summary changes:
- tonistiigi/fsutil#195
  receive: ensure callback errors are propagated
- tonistiigi/fsutil#196
  Fix file transfers from windows to linux
  fixes moby#4741
- tonistiigi/fsutil#197
  recv: translate linkname to wire format

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
@profnandaa profnandaa force-pushed the vendor-github_tonistiigi_fsutils branch from 67193bb to 64ea9da Compare April 22, 2024 09:49
@profnandaa
Copy link
Collaborator Author

@crazy-max -- thanks, fixed.

@profnandaa profnandaa marked this pull request as ready for review April 22, 2024 09:52
@jedevc
Copy link
Member

jedevc commented Apr 22, 2024

Thanks for following up with this @profnandaa 🎉

@tonistiigi tonistiigi merged commit 108cd50 into moby:master Apr 22, 2024
73 checks passed
@profnandaa profnandaa deleted the vendor-github_tonistiigi_fsutils branch May 15, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCOW: Build context with nested directories fails with "unclean path"
4 participants