Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotecache: fix missing CheckDescriptor method #4771

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

tonistiigi
Copy link
Member

fixes #4765

This method is needed by GHA cache backend to detect if Github deletes blobs from the cache because of
storage caps. It went missing when Info() support was added in #4558 for the same issue as #4558 (comment) . Later #4694 added back stargz method but not CheckDescriptor.

Overall we need to find a safer approach to this, especially because it is impossible to test because of being controlled by Github's storage. For this case, I think CheckDescriptor is not really needed anymore but can be replaced with Info() as commented in #4558 (comment) . But the stragz methods should not rely on interface detection either. The current PR is the minimal change that we can pick to v0.13 branch.

@vvoland @ktock

@gibsondan and others, please confirm your build was importing cache from GHA.

This method is needed by GHA cache backend to detect
if Github deletes blobs from the cache because of
storage caps. It got missing when Info() support was
added.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@ktock
Copy link
Collaborator

ktock commented Mar 18, 2024

LGTM about this patch.

a safer approach to this

For avoiding interface detection, maybe we should define the type that explicitly defines all necessary methods and use it for *solver.Remote.Provider?

@gibsondan
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"cache key: blob not found" error after upgrading from buildkit 12.1 to 13.0
5 participants