Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carry 4558] util/multiprovider: Implement Info #4694

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ktock
Copy link
Collaborator

@ktock ktock commented Feb 26, 2024

This PR carries #4558 (reverted in #4686), fixing the patch to pass CI.
Based on that PR, this PR adds a patch (ca58fc5) to fix DescriptorProviderPair to export methods used by multiprovider (UnlazySession and SnapshotLabels).

vvoland and others added 2 commits February 26, 2024 23:16
Require base provides to implement both content.InfoReaderProvider.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@tonistiigi tonistiigi added this to the v0.13.0 milestone Feb 26, 2024
@ktock ktock marked this pull request as ready for review February 27, 2024 01:45
@tonistiigi
Copy link
Member

@vvoland PTAL

Copy link
Collaborator

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thanks!

@crazy-max crazy-max merged commit 03caf1a into moby:master Feb 27, 2024
72 checks passed
@ktock ktock deleted the carry-4558 branch February 27, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants