[v0.12] v0.12.2 cherry-picks #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MultiWriter` would create an unnecessary map allocation when the `Write` method was used. The `Write` method would create a progress object with the meta field initialized to the meta field of the writer itself. It then invoked its own `WriteRawProgress` method which would see two maps with the metadata and erroneously believe that they were different and needed to be merged into a single metadata map. Since this map is initialized with the metadata of the writer before `WriteRawProgress` is invoked, this merge was unnecessary and could add a lot of unnecessary memory allocations during a build. This changes the `MultiWriter.Write` method to invoke the private `writeRawProgress` which performs the actual write and avoids the metadata merge. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com> (cherry picked from commit 4c83fcf)
Instead of available space. Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit a6e42ec)
Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit 49c848e)
crazy-max
approved these changes
Aug 23, 2023
jedevc
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@crazy-max @jsternberg