Update parse model URI to prevent breaking old cases while supporting aliases #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for 17053c8 will be available here when this CircleCI job completes successfully. More info
|
|
@arpitjasa-db Thank you for the contribution! Could you fix the following issue(s)? ⚠ DCO checkThe DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details. |
github-actions
bot
added
area/model-registry
… aliases Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
dbczumar
reviewed
Apr 25, 2023
dbczumar
reviewed
Apr 25, 2023
BenWilson2
reviewed
Apr 25, 2023
BenWilson2
reviewed
Apr 25, 2023
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
dbczumar
reviewed
Apr 25, 2023
dbczumar
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
LGTM once https://github.com/mlflow/mlflow/pull/8322/files#r1177120097 is addressed. Thanks @arpitjasa-db !
BenWilson2
reviewed
Apr 25, 2023
harupy
reviewed
Apr 25, 2023
harupy
reviewed
Apr 25, 2023
dbczumar
reviewed
Apr 25, 2023
dbczumar
requested changes
Apr 25, 2023
There was a problem hiding this comment.
Requesting changes until https://github.com/mlflow/mlflow/pull/8322/files#r1177158990 is addressed
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
harupy
approved these changes
Apr 26, 2023
dbczumar
approved these changes
Apr 26, 2023
BenWilson2
approved these changes
Apr 26, 2023
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
33 tasks
lobrien
pushed a commit
to lobrien/mlflow
that referenced
this pull request
May 10, 2023
… aliases (mlflow#8322) * Update parse model URI to prevent breaking old cases while supporting aliases Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Applied comments Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Addressed comments Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Allow fragments false Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> --------- Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Signed-off-by: Larry O’Brien <larry.obrien@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#8164
What changes are proposed in this pull request?
This PR fixes model naming and other URI regressions caused by #8164, while still maintaining the aliases logic.
How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes