-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate whitespace collapsing logic for TextGeneration pipelines #8294
Isolate whitespace collapsing logic for TextGeneration pipelines #8294
Conversation
…ate logic Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Documentation preview for 49a7e56 will be available here when this CircleCI job completes successfully. More info
|
mlflow/transformers.py
Outdated
data_out.startswith(data_in + "\n\n") | ||
and flavor_config[_INSTANCE_TYPE_KEY] in self._supported_custom_generator_types | ||
and not include_prompt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data_out.startswith(data_in + "\n\n") | |
and flavor_config[_INSTANCE_TYPE_KEY] in self._supported_custom_generator_types | |
and not include_prompt | |
not include_prompt | |
and flavor_config[_INSTANCE_TYPE_KEY] in self._supported_custom_generator_types | |
and data_out.startswith(data_in + "\n\n") |
We can modify the condition order here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch on the short circuit :) TY!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once https://github.com/mlflow/mlflow/pull/8294/files#r1174249495 is addressed
* pin r version due to broken devtools in latest release Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com> * fix lint Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com> --------- Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
… prediction input (mlflow#8291) * Fix openai implementation Signed-off-by: harupy <hkawamura0130@gmail.com> * default value Signed-off-by: harupy <hkawamura0130@gmail.com> * remove default Signed-off-by: harupy <hkawamura0130@gmail.com> * rename Signed-off-by: harupy <hkawamura0130@gmail.com> * reuse _has_content_and_role Signed-off-by: harupy <hkawamura0130@gmail.com> * rename key Signed-off-by: harupy <hkawamura0130@gmail.com> * improve error message Signed-off-by: harupy <hkawamura0130@gmail.com> * Address comments Signed-off-by: harupy <hkawamura0130@gmail.com> * Address comments Signed-off-by: harupy <hkawamura0130@gmail.com> * Fix spark UDF example Signed-off-by: harupy <hkawamura0130@gmail.com> * Doc fixes Signed-off-by: harupy <hkawamura0130@gmail.com> * Reorganize docs Signed-off-by: harupy <hkawamura0130@gmail.com> --------- Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
…low#8294) * apply whitespace collapsing to all text generation pipelines and isolate logic Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com> Signed-off-by: Larry O’Brien <larry.obrien@databricks.com>
…ate logic
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Isolates the application of whitespace collapsing logic to not require a conditional application of prompt removal and allows for the removal to apply to any TextGenerationPipeline to remove spurious hallucinating artifacts from generators.
How is this patch tested?
Added additional test conditions and manually verified the full test suite passes locally.
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes