Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core tensorflow 2.x api example to mlflow/examples #8235

Merged
merged 19 commits into from
Apr 20, 2023
Merged

Add core tensorflow 2.x api example to mlflow/examples #8235

merged 19 commits into from
Apr 20, 2023

Conversation

dheerajnbhat
Copy link
Contributor

Related Issues/PRs

Resolve #8049 - Add Core TensorFlow Example to mlflow/examples

What changes are proposed in this pull request?

Added core tensorflow 2.x api example to mlflow/examples

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • [] No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Modified tensorflow version in examples/README.md

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Add usage examples for mlflow.tensorflow APIs for tensorflow 2.x

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions github-actions bot added area/examples Example code rn/documentation Mention under Documentation Changes in Changelogs. labels Apr 14, 2023
@github-actions
Copy link

@dheerajnbhat Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Apr 14, 2023

Documentation preview for 2603808 will be available here when this CircleCI job completes successfully.

More info

Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
@harupy
Copy link
Member

harupy commented Apr 19, 2023

@dheerajnbha thanks for the PR, left some comments!

dheerajnbhat and others added 7 commits April 19, 2023 17:13
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
@dheerajnbhat
Copy link
Contributor Author

Hi @harupy, I have updated as per your comments. Can you review the changes made?

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments, otherwise LGTM!

dheerajnbhat and others added 3 commits April 20, 2023 08:31
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
mlflow depends on pandas, so removing pandas dependency

Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
dheerajnbhat and others added 4 commits April 20, 2023 08:46
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
mlflow depends on pandas

Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
dheerajnbhat and others added 2 commits April 20, 2023 09:10
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Dheeraj Bhat <dheerajnbhat@gmail.com>
@harupy harupy enabled auto-merge (squash) April 20, 2023 06:52
@harupy harupy merged commit 5e3b890 into mlflow:master Apr 20, 2023
22 checks passed
@harupy
Copy link
Member

harupy commented Apr 20, 2023

@dheerajnbhat Merged, thanks for the PR!

@dheerajnbhat dheerajnbhat deleted the tf-core-example branch April 20, 2023 14:50
@dheerajnbhat dheerajnbhat restored the tf-core-example branch April 20, 2023 14:51
@dheerajnbhat dheerajnbhat deleted the tf-core-example branch April 20, 2023 14:52
@dheerajnbhat
Copy link
Contributor Author

@dheerajnbhat Merged, thanks for the PR!

Glad to contribute to mlflow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Example code rn/documentation Mention under Documentation Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add Core TensorFlow Example to mlflow/examples
3 participants