New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove shap as core dependency #8199
Conversation
Documentation preview for 57fd4d8 will be available here when this CircleCI job completes successfully. More info
|
I'll fix up the failing tests. Would it be worth adding a ci test against python 3.11 at all? |
Landed on installing shap for the tests vs. removing it entirely and checking the for error logs. That seems to make more sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution @jmahlik :)
@sunishsheth2009 any objections to having a card not populated so that we don't have to have shap as a hard dependency? |
I think this makes sense. Maybe we should add it here in that case: https://github.com/mlflow/recipes-examples/blob/main/requirements.txt |
Rebased to resolve the conflict. |
Looks like some possibly flakey tests failing for 404's on installing pyspark and mlleap serialization. |
@jmahlik those test failures were due to the release of PySpark3.4 and a recent breaking release of mlserver. They've been fixed in master. :) |
Signed-off-by: Justin Mahlik <38999128+jmahlik@users.noreply.github.com>
Rebased. |
Thanks for another great contribution @jmahlik 🎉 |
Related Issues/PRs
Closes #7681
What changes are proposed in this pull request?
Moving shap to an extra and gating the shap tab in recipes behind shap being installed. This was the one place I could find with a hard dependency on shap. Happy to make other adjustments if there are places that were missed.
This likely can be classed as a bug fix. I'm not sure if it would be considered a breaking change, since users will have to install mlflow and manage the shap install separately. It should for sure be mentioned in the release notes.
How is this patch tested?
Tested most of the relevant functionality without shap installed on 3.11. It's quite hard to run the full test suite on Windows/3.11 since some of the extra ml requirements are not readily installable.
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
Move
shap
to an extra ml requirement to improve python 3.11 compatibility. Shap needs to be installed separately for the shap functionality in autologging/recipies.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes