Fix delete_experiment and restore_experiment in FileStore implementation
#8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusschlegel
changed the title
delete_experiment and restore_experiment in file_store implementation (#8177)
github-actions
bot
added
area/tracking
|
Documentation preview for c17782a will be available here when this CircleCI job completes successfully. More info
|
WeichenXu123
reviewed
Apr 6, 2023
mlflow/store/tracking/file_store.py
Outdated
Comment on lines
440
to
442
| raise MlflowException( | ||
| "Run '%s' metadata is in invalid state." % run_id, databricks_pb2.INVALID_STATE | ||
| ) |
There was a problem hiding this comment.
I think we don't need to raise error here but printing warning instead.
There was a problem hiding this comment.
I think we don't need to raise error here but printing warning instead.
Done.
WeichenXu123
reviewed
Apr 6, 2023
mlflow/store/tracking/file_store.py
Outdated
| "Run '%s' metadata is in invalid state." % run_id, databricks_pb2.INVALID_STATE | ||
| ) | ||
| new_info = run_info._copy_with_overrides(lifecycle_stage=LifecycleStage.ACTIVE) | ||
| self._overwrite_run_info(new_info, deleted_time=None) |
There was a problem hiding this comment.
Could you add test for fixed case in delete_experiment and restore_experiment ?
There was a problem hiding this comment.
Could you add test for fixed case in delete_experiment and restore_experiment ?
Done.
implementation (mlflow#8177) Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
mariusschlegel
force-pushed
the
fix-experiment-delete-restore-filestore
branch
from
85cf4f5
to
bb6dd99
Compare
Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
mariusschlegel
force-pushed
the
fix-experiment-delete-restore-filestore
branch
from
bb6dd99
to
8afba57
Compare
Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
mariusschlegel
changed the title
delete_experiment and restore_experiment in file_store implementation (#8177)delete_experiment and restore_experiment in file_store implementation
mariusschlegel
changed the title
delete_experiment and restore_experiment in file_store implementationdelete_experiment and restore_experiment in FileStore implementation
harupy
reviewed
Apr 12, 2023
mlflow/store/tracking/file_store.py
Outdated
| _validate_batch_log_data, | ||
| _validate_batch_log_limits, | ||
| _validate_experiment_id, | ||
| _validate_experiment_name, |
There was a problem hiding this comment.
Do we need to sort import statements to fix the issue? If we don't need to, we shouldn't.
There was a problem hiding this comment.
OK, I have reverted the sorting of the import statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#8177What changes are proposed in this pull request?
(Please fill in changes proposed in this fix)
How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
Fix persistent updating of
lifecycle_stageof experiments and related runs when deleting/restoring experiments with FileStore backend (#8178, @mariusschlegel).What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes