-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Registered Model Alias Endpoints and Update RegisteredModel/ModelVersion Payloads #8055
Conversation
Documentation preview for 091d1e4 will be available here when this CircleCI job completes successfully. More info
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some open questions on the direction of this PR
@@ -1,12 +1,14 @@ | |||
from mlflow.entities.model_registry.registered_model import RegisteredModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add docs to this PR or in a follow-up PR? It's already rather large and don't want to make it too big, but will follow best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave that for a follow up ;)
Looks like you'll have to override these methods in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, LGTM once they are resolved!
For this next block of failing tests, I'd try:
|
…Version Payloads Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looks like there are just 2 test-suite related failures. Great work!
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-LGTM
…Version Payloads (mlflow#8055) * Add Registered Model Alias Endpoints and Update RegisteredModel/ModelVersion Payloads Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Applied comments Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Added to unity catalog Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Fix tests Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Fixed tests Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * switch order to make the sql overlords happy Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Added delete cascade Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Update latest_schema Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * fixed tests Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Fixed tests Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Fixed tests Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> * Add validation tests Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> --------- Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Related Issues/PRs
#8001
What changes are proposed in this pull request?
Add SetRegisteredModelAlias, DeleteRegisteredModelAlias, and GetModelVersionByAlias methods to
file_store
,rest_store
, andsqlalchemy_store
. Also updateRegisteredModel
payload to have analiases
field that returns a map of aliases to version numbers, andModelVersion
payload to have analiases
field that returns a list of aliases associated with the version.How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
Add SetRegisteredModelAlias, DeleteRegisteredModelAlias, and GetModelVersionByAlias methods to
file_store
,rest_store
, andsqlalchemy_store
. Also updateRegisteredModel
payload to have analiases
field that returns a map of aliases to version numbers, andModelVersion
payload to have analiases
field that returns a list of aliases associated with the version.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes