Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom domain git (change git regex) #7933

Merged
merged 9 commits into from Mar 15, 2023
Merged

Conversation

gusghrlrl101
Copy link
Contributor

@gusghrlrl101 gusghrlrl101 commented Mar 2, 2023

Related Issues/PRs

Resolve #7853

What changes are proposed in this pull request?

Merge gitHubRegex and gitLabRegex to gitRegex.
Add newgitRegex. (Allow any domain to contain git)

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Mar 2, 2023

Documentation preview for 52d1922 will be available here when this CircleCI job completes successfully.

More info

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

@gusghrlrl101 Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/projects MLproject format, project running backends area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/feature Mention under Features in Changelogs. labels Mar 2, 2023
gusghrlrl101 added 2 commits March 2, 2023 19:45
Signed-off-by: gusghrlrl101 <gusghrlrl101@gmail.com>
Signed-off-by: gusghrlrl101 <gusghrlrl101@gmail.com>
@gusghrlrl101
Copy link
Contributor Author


스크린샷 2023-03-03 오전 11 20 23

In my case, hypertext link works well in Source, Git Commit.
(Also, it works mlflow sample in github too)

gusghrlrl101 and others added 4 commits March 3, 2023 10:21
Signed-off-by: gusghrlrl101 <gusghrlrl101@gmail.com>
Signed-off-by: gusghrlrl101 <gusghrlrl101@gmail.com>
Signed-off-by: gusghrlrl101 <gusghrlrl101@gmail.com>
Signed-off-by: gusghrlrl101 <gusghrlrl101@gmail.com>
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @gusghrlrl101 !

@gusghrlrl101
Copy link
Contributor Author

Thank you for checking.

I'd wait for merging 🙏🏼

Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: Corey Zumar <39497902+dbczumar@users.noreply.github.com>
Signed-off-by: Harutaka Kawamura <hkawamura0130@gmail.com>
Signed-off-by: GodHyum <38372691+gusghrlrl101@users.noreply.github.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harupy harupy enabled auto-merge (squash) March 15, 2023 01:02
@gusghrlrl101
Copy link
Contributor Author

@harupy

Why did this CI run fail..?

@harupy
Copy link
Member

harupy commented Mar 15, 2023

we can ignore the error

@harupy harupy disabled auto-merge March 15, 2023 07:19
@harupy harupy merged commit 97cec4d into mlflow:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects MLproject format, project running backends area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/feature Mention under Features in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add custom domain git
5 participants