Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce crewai tracing #13903

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Conversation

TomeHirata
Copy link
Collaborator

@TomeHirata TomeHirata commented Nov 28, 2024

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# Use `%sh` to run this command on Databricks
OPTIONS=$(if pip freeze | grep -q 'mlflow @ git+https://github.com/mlflow/mlflow.git'; then echo '--force-reinstall --no-deps'; fi)
pip install $OPTIONS git+https://github.com/mlflow/mlflow.git@refs/pull/13903/merge

Checkout with GitHub CLI

gh pr checkout 13903

Related Issues/PRs

#xxx

N/A

What changes are proposed in this pull request?

Context

CrewAI is a popular framework for orchestrating AI agents with more than 20k stars on Github as of Nov 26, 2024. Because of the popularity of the framework, we would like to integrate mlflow tracing with CrewAI.

What is the change

This PR introduces an auto-tracing integration with CrewAI. Users can enable the auto-tracing with mlflow.crewai.autolog() and see the tracing on the mlflow tracking server, like the picture below.

Screenshot 2024-11-28 at 18 49 24

Supported versions

v0.80.0 ~ v0.83.0

Known limitation

Due to some technical challenges in the current safe patch logic, asynchronous methods are not covered by auto-tracing now.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Sorry, something went wrong.

@github-actions github-actions bot added area/docs Documentation issues area/examples Example code rn/feature Mention under Features in Changelogs. labels Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Documentation preview for 0dd0779 will be available when this CircleCI job
completes successfully.

More info

@TomeHirata TomeHirata force-pushed the feat/crewai-autotracing branch 2 times, most recently from 3a4c596 to 2d50d17 Compare November 28, 2024 10:28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great test coverage!😁

@TomeHirata TomeHirata force-pushed the feat/crewai-autotracing branch from 0a7f509 to 5d3b0f8 Compare December 2, 2024 09:58

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
fix doc

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
@TomeHirata TomeHirata force-pushed the feat/crewai-autotracing branch from 5d3b0f8 to f371138 Compare December 2, 2024 10:01
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once this comment is addressed!

Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
@TomeHirata TomeHirata force-pushed the feat/crewai-autotracing branch from 9086ffa to 0dd0779 Compare December 3, 2024 06:54
@TomeHirata TomeHirata enabled auto-merge December 3, 2024 06:54
@TomeHirata TomeHirata added this pull request to the merge queue Dec 3, 2024
Merged via the queue into mlflow:master with commit e0254d9 Dec 3, 2024
42 checks passed
@TomeHirata TomeHirata deleted the feat/crewai-autotracing branch December 3, 2024 08:05
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Dec 9, 2024
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
karthikkurella pushed a commit to karthikkurella/mlflow that referenced this pull request Jan 30, 2025
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: k99kurella <karthikkurella4@gmail.com>
karthikkurella pushed a commit to karthikkurella/mlflow that referenced this pull request Jan 30, 2025
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: k99kurella <karthikkurella4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation issues area/examples Example code rn/feature Mention under Features in Changelogs. v2.18.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants