Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: dependency ceiling markdown>=3.3,<3.6 acts as a timebomb #143

Closed
ssbarnea opened this issue Mar 25, 2024 · 4 comments
Closed

bug: dependency ceiling markdown>=3.3,<3.6 acts as a timebomb #143

ssbarnea opened this issue Mar 25, 2024 · 4 comments
Assignees

Comments

@ssbarnea
Copy link
Contributor

ssbarnea commented Mar 25, 2024

Description of the bug

This dependency "time-bomb" was recently introduced in cd93ee3 - i supposed as it was known that the new ones cased some failures.

Expected behavior

Be compatible with latest versions of its dependencies, especially as other mkdocs plugins might rely newer versions, so a conflict could happen.

Usually I prefer to have a different pipeline that tests unreleased versions of major major dependencies, so I know when they are about the break before they release. This sorts the problems of having to add ceiling when problems are encountered.

Environment information

python -m mkdocstrings_handlers.python.debug  # | xclip -selection clipboard

PASTE OUTPUT HERE

Additional context

@pawamoy
Copy link
Member

pawamoy commented Mar 25, 2024

From https://github.com/ansible/ansible-navigator/actions/runs/8408879265/job/23025573920?pr=1721:

The user requested (constraint) markdown==3.6

Does this constraint come from dependabot or from the project itself? If the latter, do you actually require markdown==3.6? This version is indeed breaking some features of mkdocstrings-python, this is why I added the cap.

In any case, I agree that mkdocstrings-python should support markdown 3.6. I just didn't get to it yet 🙂

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Mar 25, 2024

Yep, it should support 3.6. I only mentioned the other things for the future. To avoid similar problem when 3.7 is released.

I know how to bypass it but better not to have.

@pawamoy
Copy link
Member

pawamoy commented Mar 25, 2024

Yup, I usually never cap my dependencies.

Usually I prefer to have a different pipeline that tests unreleased versions of major major dependencies, so I know when they are about the break before they release. This sorts the problems of having to add ceiling when problems are encountered.

In this particular case, I knew 3.6 would break mkdocstrings-python before it was released, so I added the cap before the release (in sync with @waylan, Python-Markdown's maintainer). Since this won't change in 3.7+, I didn't just exclude 3.6 with !=3.6. Also, the breakage is not easily detected, at least not with our current test suite. I have it in my backlog to add end-to-end tests to facilitate detecting such breakages. Lots of work 😄

@pawamoy
Copy link
Member

pawamoy commented Apr 2, 2024

Fixed. For reference: Python-Markdown/markdown#1441, mkdocstrings/mkdocstrings@c0d0090.

@pawamoy pawamoy closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants