Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make custom_templates relative to config file #627

Merged
merged 8 commits into from Oct 26, 2023
Merged

Make custom_templates relative to config file #627

merged 8 commits into from Oct 26, 2023

Conversation

waylan
Copy link
Contributor

@waylan waylan commented Oct 20, 2023

Fixes #477.

I have not even looked at tests, etc. But this should be working code.

@waylan
Copy link
Contributor Author

waylan commented Oct 20, 2023 •
edited

I had very limited time today. I will come back to this later. Or you can run with it if you want.

@waylan
Copy link
Contributor Author

waylan commented Oct 23, 2023

It appears that the tests are all failing due to an unrelated issue:

 DeprecationWarning: 'materialx.emoji.twemoji' is deprecated.
  Material emoji logic has been officially moved into mkdocs-material
  version 9.4. Please use Material's 'material.extensions.emoji.twemoji'
  as mkdocs_material_extensions is deprecated and will no longer be
  supported moving forward. This is the last release.

@pawamoy pawamoy self-requested a review October 23, 2023 13:09
@pawamoy pawamoy self-assigned this Oct 23, 2023
pawamoy
pawamoy approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This is looking good.

src/mkdocstrings/plugin.py Outdated Show resolved Hide resolved
waylan and others added 2 commits October 25, 2023 13:41
@waylan @pawamoy
Fix Capitalization
4b1cd44 
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
@waylan
Add tests
00f92ae
@waylan waylan marked this pull request as ready for review October 25, 2023 19:10
@waylan
Copy link
Contributor Author

waylan commented Oct 25, 2023

Now that I have added tests, this should be ready to go. I'm ignoring the unrelated failing tests.

pawamoy
pawamoy reviewed Oct 25, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pawamoy
Copy link
Member

pawamoy commented Oct 25, 2023

Thanks for the tests. It seems the other ones are failing because pymdownx is missing from the test group. I'll fix that in another commit/PR 🙂

@waylan
Revert "Update Changelog"
5c1e166 
This reverts commit ca14b66.
@pawamoy pawamoy merged commit 370a61d into mkdocstrings:main Oct 26, 2023
1 of 17 checks passed
@waylan waylan deleted the patch-1 branch October 26, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees

@pawamoy pawamoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make custom_templates relative to mkdocs.yml
2 participants
@waylan @pawamoy