Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readthedocs theme expanding all top level ToC entries #3464

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix readthedocs theme expanding all top level ToC entries #3464

merged 2 commits into from
Nov 21, 2023

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Nov 11, 2023

ultrabug
ultrabug approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that upstream ?

@oprypin
Copy link
Contributor Author

oprypin commented Nov 20, 2023

Nope, not upstream ☹️

#3292 (comment)

It is too difficult to exactly stay with upstream because the theme in mkdocs went beyond the capabilities of the upstream theme. Their JS code does not expect that any nav item can expand into sub-items. In the upstream theme only the currently opened section is possible to expand.

@oprypin oprypin merged commit eaf4e4f into master Nov 21, 2023
30 checks passed
@oprypin oprypin deleted the rtnav branch November 21, 2023 20:10
@oprypin oprypin mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultrabug ultrabug ultrabug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readthedocs theme expanding all top level ToC entries
2 participants
@oprypin @ultrabug