Added Pulse.get_sink_by_name and Pulse.get_source_by_name #17
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am writing a tool for implementing the function row in Python. To do so, I needed some extra functionality from libpulse, the ability to get a sink given a name.
Yes, I know one could get a list of all the sinks and search them, but, what happens if you want to do this multiple times per second? What happens if you want to use things like
@DEFAULT_SINK@
? You need to usepa_get_sink_info_by_name()
. Using a patched version of pulsectl with this function wrapped gave me a 33% reduction in average memory use for my program.I urge you to merge this.