Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RULES.md for MD007 #462

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

ColemanTom
Copy link
Contributor

Description

Fixing some minor errors in the RULES.md for MD007.

Related Issues

!433

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (non-breaking change that does not add functionality but updates documentation)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • Wrote good commit messages
  • Feature branch is up-to-date with master, if not - rebase it
  • Added tests for all new/changed functionality, including tests for positive and negative scenarios
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences

Sorry, something went wrong.

Copy link
Member

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Change looks good, but you'll need to sign-off on your commits. See the CONTRIBUTING DOC which also has several other links for reference.

MD007 examples showed 3 space indent as bad, but 2 as good.
The rule had been changed a while ago to make 3 good and 2 bad.

Also changed one instance where it said 2 was default.

Signed-off-by: Tom Coleman <15375218+ColemanTom@users.noreply.github.com>
@ColemanTom ColemanTom force-pushed the ColemanTom-Issue433 branch from 0296b2d to c52ccf1 Compare July 13, 2023 04:42
@ColemanTom
Copy link
Contributor Author

Thanks! Change looks good, but you'll need to sign-off on your commits. See the CONTRIBUTING DOC which also has several other links for reference.

Thanks. I thought I had, but maybe I just thought about doing that. It should be signed now.

@jaymzh jaymzh merged commit faffaf7 into markdownlint:main Jul 13, 2023
@ColemanTom ColemanTom deleted the ColemanTom-Issue433 branch July 20, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants